feat(tracemetrics): Add trace metrics behind an experiments flag #17883
+894
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the js sdk to send in new trace metric protocol items, although this code is experimental since the schema may still change. Most of this has been copied from logs so some parts may need to be modified / removed later (eg. buffer) but this should allow us to start on UI work by sending in larger amounts of data from sentry js app to test grouping / aggregations etc.
…dd-experimental-metrics
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
| if (_enableTraceMetrics) { | ||
| _INTERNAL_flushMetricsBuffer(this); | ||
| } |
There was a problem hiding this comment.
Bug: Syntax Error in Visibility Change Handler
A missing closing brace for the if (_enableTraceMetrics) block within the visibilitychange event handler causes a syntax error.
| if (metricBuffer.length >= MAX_METRIC_BUFFER_SIZE) { | ||
| _INTERNAL_flushMetricsBuffer(client, metricBuffer); | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: Metric Loss During Buffer Flush
When the metric buffer reaches its maximum size, a newly captured metric is added to the buffer before the flush condition is evaluated. If a flush is triggered, it processes the buffer before the new metric was added. Subsequently, the entire buffer is cleared, causing the newly added metric to be lost and never sent.
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows the js sdk to send in new trace metric protocol items, although this code is experimental since the schema may still change. Most of this has been copied from logs so some parts may need to be modified / removed later (eg. api, buffer) but this should allow us to start on UI work by sending in larger amounts of data from sentry js app to test grouping / aggregations etc.