feat(cloudflare): Add console integration #16021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
stephanie-anderson,
andreiborza and
Lms24
and removed request for
a team
Lms24
approved these changes
Apr 10, 2025
|
Good call on tests! It also inspired me to approach this in a slightly different fashion. Let me try another approach. |
|
Superceded by #16024 |
AbhiPrasad
added a commit
that referenced
this pull request
Apr 10, 2025
…vercel-edge (#16024) resolves #15439 resolves #4532 resolves https://linear.app/getsentry/issue/JSC-192 Supercedes #16021 Our console instrumentation was always inconsistent, but adding breadcrumbs should not really be. This PR adds a unified console instrumentation to `@sentry/core`, and makes the Node SDK use that. We also add this to the `vercel-edge` and `cloudflare` SDKs. I also left todo comments in the deno and browser SDKs for us to unify into this single integration afterwards. --------- Co-authored-by: Francesco Gringl-Novy <francesco.novy@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #15439
resolves https://linear.app/getsentry/issue/JSC-192
Add console integration to cloudflare SDK. Unfortunately can't access Node.js APIs, so we have to use
safeJoinoverutil.formatfromnode:utilwhen creating the console message.