fix(node): Make log flushing logic more robust #15991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
mydea and
lforst
and removed request for
a team
AbhiPrasad
commented
Apr 7, 2025
| @@ -25,6 +25,9 @@ import { resolvedSyncPromise } from './utils-hoist/syncpromise'; | |||
| import { _INTERNAL_flushLogsBuffer } from './logs/exports'; | |||
| import { isPrimitive } from './utils-hoist'; | |||
|
|
|||
| // TODO: Make this configurable | |||
| const DEFAULT_LOG_FLUSH_INTERVAL = 5000; | |||
There was a problem hiding this comment.
This also exists in the browser SDK.
I'm going to create another PR after this that unifies this as a logging option, and update the develop docs as well.
size-limit report 📦
|
lforst
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://linear.app/getsentry/issue/LOGS-18
We got some user feedback that nodejs logging was too inconsistent. This PR improves that.
flushLogsclient hook that allows us to reset server weight tracking logic more consistently. This also fixes a bug where we didn't reset weight tracking when callingSentry.flush.process.on('beforeExit'listener to flush logs. Hooking ontobeforeExitdoes not guarantee we flush all logs before exit, but it does increase the chances we do.