fix(cjs): Use module instead of require for CJS check
#15927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Mar 31, 2025
lforst
reviewed
Mar 31, 2025
packages/node/src/utils/commonjs.ts
Outdated
| @@ -1,4 +1,4 @@ | |||
| /** Detect CommonJS. */ | |||
| export function isCjs(): boolean { | |||
| return typeof require !== 'undefined'; | |||
| return typeof module !== 'undefined' && typeof module.exports !== 'undefined'; | |||
There was a problem hiding this comment.
Why are we also checking for module.exports?
There was a problem hiding this comment.
Just some additional safety as there is maybe a variable named module. But it's more unlikely that there is one that is an object with the key exports.
mydea
reviewed
Mar 31, 2025
size-limit report 📦
|
mydea
reviewed
Mar 31, 2025
| @@ -1,4 +1,8 @@ | |||
| /** Detect CommonJS. */ | |||
| export function isCjs(): boolean { | |||
| return typeof require !== 'undefined'; | |||
| try { | |||
There was a problem hiding this comment.
IMHO if we do the try catch, we can omit the && module check xD as we should be safe already!
3 tasks
3 tasks
onurtemizkan
pushed a commit
that referenced
this pull request
Apr 3, 2025
As `require` is supported in ESM as well from [Node 20.19.0](https://nodejs.org/en/blog/release/v20.19.0) onwards, the check does not work anymore. However, `module` is not available in ESM. Also mentioned in this comment: #14202 (comment) [Node: Compatibility with CommonJS](https://nodejs.org/docs/latest-v15.x/api/esm.html#esm_interoperability_with_commonjs) [Bun: Using require](https://bun.sh/docs/runtime/modules#using-require)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
requireis supported in ESM as well from Node 20.19.0 onwards, the check does not work anymore. However,moduleis not available in ESM.Also mentioned in this comment: #14202 (comment)
Node: Compatibility with CommonJS
Bun: Using require