Skip to content

ref(core): Ensure non-recording root spans have frozen DSC #14964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 9, 2025

Otherwise, parts of the DSC will be missing - we try to make it as complete as we can.

Since the span cannot be updated anyhow (e.g. the name cannot be changed), we can safely freeze this at this time.

Extracted out of #14955

@mydea mydea requested a review from Lms24 January 9, 2025 15:25
@mydea mydea self-assigned this Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.07 KB - -
@sentry/browser - with treeshaking flags 21.73 KB - -
@sentry/browser (incl. Tracing) 35.6 KB +0.14% +48 B 🔺
@sentry/browser (incl. Tracing, Replay) 72.38 KB +0.07% +47 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.9 KB +0.09% +55 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 76.64 KB +0.07% +49 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 88.68 KB +0.06% +47 B 🔺
@sentry/browser (incl. Feedback) 39.34 KB - -
@sentry/browser (incl. sendFeedback) 27.7 KB - -
@sentry/browser (incl. FeedbackAsync) 32.51 KB - -
@sentry/react 25.76 KB - -
@sentry/react (incl. Tracing) 38.37 KB +0.15% +55 B 🔺
@sentry/vue 27.28 KB +0.16% +43 B 🔺
@sentry/vue (incl. Tracing) 37.43 KB +0.17% +65 B 🔺
@sentry/svelte 23.19 KB - -
CDN Bundle 24.35 KB - -
CDN Bundle (incl. Tracing) 35.92 KB +0.17% +62 B 🔺
CDN Bundle (incl. Tracing, Replay) 70.56 KB +0.09% +59 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 75.74 KB +0.09% +64 B 🔺
CDN Bundle - uncompressed 71.14 KB - -
CDN Bundle (incl. Tracing) - uncompressed 106.65 KB +0.14% +145 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 217.66 KB +0.07% +145 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 230.34 KB +0.07% +145 B 🔺
@sentry/nextjs (client) 38.5 KB +0.16% +61 B 🔺
@sentry/sveltekit (client) 36.15 KB +0.17% +61 B 🔺
@sentry/node 161.77 KB -0.01% -1 B 🔽
@sentry/node - without tracing 97.54 KB +0.01% +1 B 🔺
@sentry/aws-serverless 127.42 KB - -

View base workflow run

Otherwise, parts of the DSC will be missing - we try to make it as complete as we can.
@mydea mydea force-pushed the fn/freeze-non-recording-span-dsc branch from 555c009 to 4056db6 Compare January 9, 2025 17:12
@mydea mydea merged commit 1d98867 into develop Jan 10, 2025
153 checks passed
@mydea mydea deleted the fn/freeze-non-recording-span-dsc branch January 10, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants