Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: All Sentry.feedbackIntegration examples include the Sentry.init() statement for clarity #13247

Merged
merged 2 commits into from
Apr 4, 2025

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Apr 4, 2025

These examples were really confusing. I think we wrote them assuming that people would first read the 'default' setup steps, then come here to tweak that afterwards. I think each example should stand alone though, so people don't have to read everything in order to just copy+paste and get going.

Fixes getsentry/sentry-javascript#15977

Copy link

vercel bot commented Apr 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 11:21pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2025 11:21pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2025 11:21pm

Copy link

codecov bot commented Apr 4, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.13MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/PGygBXULQr3lwiZX3V4Fw/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/PGygBXULQr3lwiZX3V4Fw/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/5VjVU8szhtAqL5oYrnjhh/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/5VjVU8szhtAqL5oYrnjhh/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@ryan953 ryan953 merged commit ef62537 into master Apr 4, 2025
11 checks passed
@ryan953 ryan953 deleted the ryan953/feedback-example-incl-sentry-init branch April 4, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants