fix(ui): Link rendering in comment editor #1371
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses new npm dependency @tiptap/extension-link to fix link rendering Previously links would be stripped from the editor in rich text mode This extension allows users to: - Insert links using markdown syntax in markdown mode - Paste links directly in rich text mode - Preserve links when toggling between modes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue: Fixes: #1370
Uses new npm dependency
@tiptap/extension-linkto fix link rendering. Previously links would be stripped from the editor in rich text mode. This extension allows users to:Validation
Here's a loom explaining the current bug and highlighting the new fix
Notes
CommentEditorcomponent, but I might have missed it. I tried creating a new test file but wasn't having a little trouble hooking it into the existing test harness. If you want an accompanying unit test, I can spend bit more time on getting it to work!MenuBarcomponent, but I was trying to keep the surface area of this PR pretty small. If it would be helpful to add that link button I can try to tackle that in a separate enhancement PR.