forked from facebook/create-react-app
-
Notifications
You must be signed in to change notification settings - Fork 1
Add REACT_APP_INJECT_STYLES to allow injecting generated styles into window variable #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
redbugz
merged 14 commits into
frontierMaster
from
rileytb/EOLBFRST-921_hf-inj-react-webpack-setup
Mar 11, 2025
Merged
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
310452e
Add REACT_APP_INJECT_STYLES to allow injecting generated styles into …
rileytb 8040ec9
Add script injection from manifest entrypoints
rileytb 07e8cd0
Updating style injection for prod
rileytb 7c5b438
version bump
rileytb fb2ca13
Update packages/react-scripts/config/webpack.config.js
rileytb 87f698c
Update packages/react-scripts/package.json
rileytb 11de689
Update packages/react-scripts/config/webpack.config.js
rileytb 6bfc452
Update packages/react-scripts/config/webpack.config.js
rileytb 39f2d74
Update packages/react-scripts/config/webpack.config.js
rileytb 2825ca5
version change
rileytb 2f4cdd5
fix version bump
rileytb f242bd0
Simplify env vars; fix plugin variable names
rileytb 5a9e6e7
Change hf scripts output to json file
rileytb 4936cc1
add directory for hf script output files
rileytb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
'use strict'; | ||
const { getCompilerHooks } = require('webpack-manifest-plugin'); | ||
const fs = require('fs'); | ||
const path = require('path'); | ||
|
||
class InjectEntrypointsPlugin { | ||
constructor(options) { | ||
this.options = options; | ||
} | ||
|
||
apply(compiler) { | ||
const {afterEmit} = getCompilerHooks(compiler) | ||
|
||
afterEmit.tap('InjectEntrypointsPlugin', (manifest) => { | ||
const outputPath = path.join( | ||
compiler.options.context, | ||
this.options.outputFile | ||
); | ||
|
||
fs.writeFileSync(outputPath, | ||
JSON.stringify( | ||
manifest.entrypoints.map((entry) => this.options.outputPath + entry)), | ||
'utf8'); | ||
}) | ||
} | ||
} | ||
|
||
module.exports = InjectEntrypointsPlugin; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entrypoints didn't have a full path (prepended w/the CDN when doing a prod build) So I needed to do this to know where to look for them. However, I am going to change this variable name because it's confusing with line 15. And it's just
paths.publicUrlOrPath
so it doesn't even need passed in