Skip to content

Add flag to disable SERVER_DATA.isLoggedIn #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 31, 2024
Merged

Add flag to disable SERVER_DATA.isLoggedIn #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
28c066b
adding flag to remove isLoggedIn
Dec 21, 2024
8133e4e
update package-lock for react script change
Dec 21, 2024
da5d924
correcting change
Dec 21, 2024
dc3c70f
Update packages/react-scripts/layout/views/layout.ejs
nicknielsen86 Dec 23, 2024
95ff04a
Update packages/react-scripts/layout/views/layout.ejs
nicknielsen86 Dec 23, 2024
f3164be
looking to skipSessionPrevalidation to set isLoggedIn
Dec 30, 2024
3cde4df
stricter equality check
redbugz Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion packages/react-scripts/layout/views/layout.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@
SERVER_DATA.sgBaseUrl = "<%= process.env.SG_BASE_URL %>"
SERVER_DATA.splitioAuthKey = "<%= process.env.SPLITIO_AUTH_KEY %>"
SERVER_DATA.geoData = <%- typeof geoData !== 'undefined' ? JSON.stringify(geoData) : JSON.stringify({}) %>;
SERVER_DATA.isLoggedIn = <%= isLoggedIn %>
<% if (typeof skipSessionPrevalidation !== 'undefined' && !skipSessionPrevalidation) { %>
SERVER_DATA.isLoggedIn = <%= isLoggedIn %>
<% } %>
<% include partials/experiments %>
<% include partials/sentry %>
<% include partials/clientAppConfig %>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@fs/react-scripts",
"version": "8.8.1",
"version": "8.8.2",
"upstreamVersion": "5.0.1",
"description": "Configuration and scripts for Create React App.",
"repository": {
Expand Down