[Android] Fixes Up the Gradle Version And RN Maven Path #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: I believe starting with RN 21 (maybe), the dependencies are no longer on maven / mavencentral but instead you reference them from the local node_modules folder. Second in order to make the Android lib project work with AS, we have to bump the gradle version. It now matches the version in the RN hello world project. :
maicki
approved these changes
Mar 13, 2018
There was a problem hiding this comment.
LGTM. We have the same settings in https://github.com/maicki/react-native-event-bridge
This was referenced Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I believe starting with RN 21 (maybe), the dependencies are no longer
on maven / mavencentral but instead you reference them from the
local node_modules folder.
Second in order to make the Android lib project work with AS, we have
to bump the gradle version. It now matches the version in the RN hello world project.
#51 & #39 - both have make too many folder level jumps. The
node_modulesfolder from the perspective of the android lib project is only one up.