Skip to content

Remove depreciated createJSModules @ovveride marker #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2017
Merged

Remove depreciated createJSModules @ovveride marker #41

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2639646
Fix for RN 0.47
radko93 Aug 2, 2017
916f456
Fix typo in comment
radko93 Aug 2, 2017
2ccd217
Fix typo in comment
radko93 Aug 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix for RN 0.47
  • Loading branch information
@radko93
radko93 authored Aug 2, 2017
commit 263964625d76c44b2946c17a7edc32b036203da8
2 changes: 1 addition & 1 deletion templates/android.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public class ${name}Package implements ReactPackage {
return Arrays.<NativeModule>asList(new ${name}Module(reactContext));
}

@Override
// Deprecated RN 0.47
public List<Class<? extends JavaScriptModule>> createJSModules() {
return Collections.emptyList();
}
Expand Down