Refactor and unification of runtime interface #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a major refactor of the runtime interface which makes it *much* easier to program against in a generic way. The most obvious changes are (1) the interface is no longer split into sync/unsync variants, (2) the runtime interface no longer requires a lifetime annotation on the machine type. The type annotations required on callback arguments have gotten a little bit harrier... I really wish Rust was better at inferring the types of closure arguments--in this case all the info is obviously there to do it. The runtime interface and its demos and tests have been updated and are working, but the code generator and integration tests have not been updated yet, so CI is expected to fail.
This change was needed so that the Send and Sync traits will propagate to structs that contain values of these associated types, when applicable. Unfortunately, Rust can't automatically propagate the associated type bounds, which means they need to be propagated everywhere that the Machine trait is used. Quite annoying from an ergonomic perspective... Here's the RFC to add the ability to automatically propagate trait bounds to Rust in the future: rust-lang/rust#52662
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major refactor of the runtime interface which makes it much easier to program against in a generic way. The most obvious changes are:
It's not all roses though. The new approach uses a set of trait bounds on the
Machinetype, and these must often be propagated to use sites. Also the type annotations required on callback arguments have gotten a little bit harrier. See the documentation for details.Both of these issues are situations where Rust should be able to infer the types/bounds but can't currently, so these drawbacks may disappear in the future as Rust improves.