Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for circleci #85

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Conversation

SIMRAN1
Copy link
Contributor

@SIMRAN1 SIMRAN1 commented Jun 10, 2018

Fixes #81
Adding support for circleCi and removing Travis CI

@ghost ghost added the needs review label Jun 10, 2018
@ghost ghost assigned SIMRAN1 Jun 10, 2018
@ghost
Copy link

ghost commented Jun 10, 2018

Hi @SIMRAN1!

It looks like one or more of your builds have failed.
I've added the relevant info below to save you some time.

@SIMRAN1
Copy link
Contributor Author

SIMRAN1 commented Jun 11, 2018

@imjog please review!!

build_and_test:
jobs:
- build-and-test

Copy link
Member

@jogendra jogendra Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the last empty line (23)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okk @imjog !!

@jogendra
Copy link
Member

@mariobehling @chashmeetsingh Please integrate the Cirlce-CI to the repo and remove Travic-CI integration.

@SIMRAN1
Copy link
Contributor Author

SIMRAN1 commented Jun 11, 2018

Done @imjog !!

@jogendra
Copy link
Member

@SIMRAN1 Remove end-space from the last line too.

Copy link
Member

@jogendra jogendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ghost ghost removed the needs review label Jun 11, 2018
@SIMRAN1
Copy link
Contributor Author

SIMRAN1 commented Jun 11, 2018

thanks @imjog !!

@mariobehling mariobehling merged commit a91cf39 into fossasia:development Jun 11, 2018
@ghost ghost added the ready-to-ship label Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants