Skip to content

Deleted .DS_Store files, added to .gitignore & resolved failing tests #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2018

Conversation

jogendra
Copy link
Member

Fixed #72

Changes:

  • Resolved the failing UI tests
  • Added .DS_Store files to .gitignore
  • Deleted existing .DS_Store

Screenshots:
N/A

Added DS_Store to .gitignore

resolved failing tests
@jogendra
Copy link
Member Author

@mariobehling @chashmeetsingh Please review the PR and merge it. This is required for PR #57 , #69 and #70

@ghost ghost removed the needs review label May 28, 2018
@chashmeetsingh chashmeetsingh merged commit 3e46250 into fossasia:development May 28, 2018
@ghost ghost added the ready-to-ship label May 28, 2018
@jogendra jogendra deleted the ds-store branch May 28, 2018 18:12
Copy link
Contributor

@SIMRAN1 SIMRAN1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var refreshControl = UIRefreshControl()
@imjog its not added in DispatchQueue

@jogendra
Copy link
Member Author

@SIMRAN1 That is not required! See tests are passing!

@SIMRAN1
Copy link
Contributor

SIMRAN1 commented May 30, 2018

okk @imjog !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants