Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where OnFocus was only getting called once #3

Merged
merged 2 commits into from
Jun 22, 2018

Conversation

erikras
Copy link
Member

@erikras erikras commented Jun 22, 2018

Fixes #2.

Also migrated from componentWillUpdate to componentDidUpdate in compliance with React.

@codecov
Copy link

codecov bot commented Jun 22, 2018

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #3   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          44     46    +2     
  Branches        5      6    +1     
=====================================
+ Hits           44     46    +2
Impacted Files Coverage Δ
src/ExternallyChanged.js 100% <100%> (ø) ⬆️
src/OnBlur.js 100% <100%> (ø) ⬆️
src/OnChange.js 100% <100%> (ø) ⬆️
src/OnFocus.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e382c8...f6ce59e. Read the comment docs.

@erikras erikras merged commit 83320f4 into master Jun 22, 2018
@erikras
Copy link
Member Author

erikras commented Jun 22, 2018

Published in v1.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant