OS-agnostic unit tests #1664
OS-agnostic unit tests #1664
Conversation
- Test results for formatCode.ts are now designed to match irrespective of the system's line separators: The previously used multi-line template strings created UNIX-style line separators, which do not match on Windows systems. Therefore, line endings are now explicitly written into the expected output string, unfortunately affecting readability. - Inside `formatCode`, input strings are now split into lines by any valid line separator. Previously, only the system's line separators have been considered, which may produce some unexpected results when receiving line endings from other systems.
- Test results for write operations are now designed to match irrespective of the system's path encoding: The previously used UNIX-style path strings do not match on Windows systems. Therefore, expected paths are now being resolved as they are in their corresponding write function. - Unit tests should now pass on all systems.
|
Hey @krokettenkoal, how did you get your pull request merged so fast? There are pull requests waiting to be merged for weeks, is there any trick to getting approved faster? |
Not really, I was surprised too tbh. I guess it's because it only affected some simple unit tests and not any actual functionality. The fixes have been very straightforward and didn't really require any additional testing. I think @ferdikoomen is still pretty busy and tries not to break anything while he wouldn't have a lot of time to fix it, which I understand. I guess we'll need some patience and keep using our own forks for now. |
3 participants
File system and code format tests should now pass on all systems. Previously, expected test results did not match on Windows systems due to their differences in line endings and path encoding. See commit messages for more details.