Skip to content

refactor: remove usage of var in babel-preset-react-app #9648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: remove usage of var in babel-preset-react-app #9648

wants to merge 1 commit into from

Conversation

tobiasbueschel
Copy link
Contributor

As discussed with @mrmckeb this PR removes the legacy usage of var within babel-preset-react-app: https://github.com/facebook/create-react-app/pull/9645/files#r489211419

tobiasbueschel
tobiasbueschel commented Sep 16, 2020
View reviewed changes
@tobiasbueschel tobiasbueschel mentioned this pull request Sep 16, 2020
Merged
tobiasbueschel
tobiasbueschel commented Sep 16, 2020
View reviewed changes
@tobiasbueschel
Copy link
Contributor Author

The fix was released in PostCSS 7.0.34. This PR can be removed.

Hi @ai, I think you might have accidentally commented on the wrong PR - this one is not related to PostCSS, but rather to the legacy usage of var.

@stale
Copy link

stale bot commented Dec 25, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Dec 25, 2020
@tobiasbueschel
Copy link
Contributor Author

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

Please keep the PR open.

@stale stale bot removed the stale label Jan 4, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 9, 2022
@tobiasbueschel
Copy link
Contributor Author

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

👋

@stale stale bot removed the stale label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasbueschel @facebook-github-bot