Skip to content

Pin babel-preset-react-app to to core-js minor '3.5' version and add a peer dependency #9021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Pin babel-preset-react-app to to core-js minor '3.5' version and add a peer dependency #9021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
caf745b
Pin to core-js 3.5.0 and add a peer dependency
Mrman May 15, 2020
c7dbf27
Update to '3.5' instead of number
Mrman May 22, 2020
291e107
Update to '3.5' instead of number
Mrman May 22, 2020
bcb0a63
Merge branch 'master' into core-js-config-change
Mrman Jan 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/babel-preset-react-app/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ module.exports = function (api, opts, env) {
// Allow importing core-js in entrypoint and use browserlist to select polyfills
useBuiltIns: 'entry',
// Set the corejs version we are using to avoid warnings in console
corejs: 3,
corejs: '3.5',
// Exclude transforms that make all code slower
exclude: ['transform-typeof-symbol'],
},
Expand Down
3 changes: 1 addition & 2 deletions packages/babel-preset-react-app/dependencies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,7 @@ module.exports = function (api, opts) {
// Allow importing core-js in entrypoint and use browserlist to select polyfills
useBuiltIns: 'entry',
// Set the corejs version we are using to avoid warnings in console
// This will need to change once we upgrade to corejs@3
corejs: 3,
corejs: '3.5',
// Exclude transforms that make all code slower
exclude: ['transform-typeof-symbol'],
},
Expand Down
3 changes: 3 additions & 0 deletions packages/babel-preset-react-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,8 @@
"@babel/runtime": "7.12.1",
"babel-plugin-macros": "2.8.0",
"babel-plugin-transform-react-remove-prop-types": "0.4.24"
},
"peerDependencies": {
"core-js": "^3.5.0"
}
}