Skip to content

Conversation

Mk-Etlinger
Copy link

Hi there,

Hope this is helpful for other people. It's not immediately clear from the docs that when clicking on a relative link, to initiate an Oauth2 flow for example, the proxy doesn't work because of the Accept header is text/html.

Happy to re-word this to make it more clear. Let me know and I can fix.

Thanks!

Hi there,

Hope this is helpful for other people. It's not immediately clear from the docs that when clicking on a relative link, to initiate an Oauth2 flow for example, the proxy doesn't work because of the Accept header is `text/html`.

Happy to re-word this to make it more clear. Let me know and I can fix.

Thanks!
@Mk-Etlinger Mk-Etlinger requested review from amyrlam and iansu as code owners June 3, 2019 21:35
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale
Copy link

stale bot commented Jul 3, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jul 3, 2019
@Mk-Etlinger
Copy link
Author

Hi there,

Putting some activity here so that this doesn't get garbage collected. Open to changing this up but need feedback.

The issue:

The basic proxy can't initiate Oauth Flow for anchor tags because of the headers needed.

The Solve:

We need add the more advanced proxy and configure it to work properly. If this were in the docs, it would save the headache that I and many others have gone through.

Thanks!

@stale stale bot removed the stale label Jul 8, 2019
@stale
Copy link

stale bot commented Aug 7, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Aug 7, 2019
@iansu iansu self-assigned this Aug 7, 2019
@amyrlam amyrlam removed their request for review August 24, 2020 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants