-
-
Notifications
You must be signed in to change notification settings - Fork 27.1k
Add the possibility to keep the js class names in the production build #6624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Is there any possibility to get this merged? |
so why no one looked at this? not even a feedback comment? this ENV variable is exactly what my projects needs right now. |
For everyone who might be searching for a solution to keep the classnames in build here is one:
In "node_modules/react-scripts/webpack.config.js" this affects
which will lead to
Props for coming up this solution go to @tstec-polypoly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving this review since I saw it in my pending requests! Best of luck with the PR! Seems to be a GitHub bug since I no longer have rights.
I added an environment variable to prevent the terser plugin from minifying js class names in the production build.
The variable is:
KEEP_CLASS_NAMES
- i added an example in the documentation, beneath the production-build documentation.There is no major change, the production build will be equal to the production build before this pull request, if there is no environment variable set.