Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] Revert to use ecma 5 in uglifyOptions #4234

Merged
merged 3 commits into from
Apr 2, 2018
Merged

[next] Revert to use ecma 5 in uglifyOptions #4234

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6777531
Revert to use ecma 5 in uglifyOptions
danielberndt Mar 31, 2018
0915f88
remove explicit ecma version from uglifyOptions settings
danielberndt Apr 1, 2018
3cc4867
be explicit of where we use ecma: 8 and ecma: 5
danielberndt Apr 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/react-scripts/config/webpack.config.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,8 +378,15 @@ module.exports = {
// Minify the code.
new UglifyJsPlugin({
uglifyOptions: {
ecma: 8,
parse: {
// we want uglify-js to parse ecma 8 code. However we want it to output
// ecma 5 compliant code, to avoid issues with older browsers, this is
// whey we put `ecma: 5` to the compress and output section
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"why"

// https://github.com/facebook/create-react-app/pull/4234
ecma: 8,
},
compress: {
ecma: 5,
warnings: false,
// Disabled because of an issue with Uglify breaking seemingly valid code:
// https://github.com/facebook/create-react-app/issues/2376
Expand All @@ -391,6 +398,7 @@ module.exports = {
safari10: true,
},
output: {
ecma: 5,
comments: false,
// Turned on because emoji and regex is not minified properly using default
// https://github.com/facebook/create-react-app/issues/2488
Expand Down