Skip to content

Conversation

tsmock
Copy link

@tsmock tsmock commented Jul 28, 2023

This is largely a PR to updated react-scripts dependencies.

Of specific note for downstream users:

  • @babel/core: Min version now 7.22.9. Note: 8.x will have breaking changes.
  • @svgr/webpack: Min version now 8.0.1, v6 migration docs indicate this might be ESM only; I have not verified this. I might have to roll it back to a v6 version.
    • https://react-svgr.com/docs/migrate/
    • Requires webpack 5 or later which we are already doing
    • Uses SVGO v3
    • Does not merge configuration anymore
    • plugin-jsx no longer included by default
  • fill in rest of react-scripts update notes

Reasons for updating dependencies:

  • Update Jest from v27 to v29
  • Make it easier to track down and fix bugs

tsmock added 9 commits July 28, 2023 06:01
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Note: Is @babel/code-frame actually necessary?

Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
@facebook-github-bot
Copy link

Hi @tsmock!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants