Respect BROWSER env var when starting webpack dev server #12522
Conversation
The `browser` option is ignored (on Mac OS X), as it is not provided correctly in the options to `open`. This attempts to fix that. Note: this needs to be tested cross-platform.
|
Hi @joostlubach! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Yup, can confirm I have the same bug with same solution on Linux as well. |
|
Ah, it looks like this is a duplicate of #11878, which got some more traction |
The browser option is ignored (at least on Mac OS X), as it is not provided correctly in the options to open. This attempts to fix that.
Note: I only have a mac, so I've tested this on Mac OS X. I suppose it needs to be tested cross-platform. On Mac, this change allows me to choose the browser through the BROWSER env var.