fix: webpack.config.js process.env.TSC_COMPILE_ON_ERROR

[YuanXingH]

in /packages/react-scripts/scripts/build.js and /packages/react-scripts/config/webpack.config.js file. When process.env.TSC_COMPILE_ON_ERROR === true,
we should report errors instead of warnings

[facebook-github-bot]

Hi @YuanXingH!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[onuralp]

The current logic is valid. The flag TSC_COMPILE_ON_ERROR means compile it even when there are errors. So it shows warnings instead of errors when it is set to true. However, to make it more clear, the flag can be renamed.