Define process.platform in react-error-overlay's iframe bundle #12351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#12212 has nothing to do with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-error-overlayis broken since 6.0.10, due to the upgrades in #11624 transitively bring in chalk into the react-error-overlay iframe bundle.chalkcallsprocess.platformwhich is not available in browsers, making the code crash. This has side effects of causing the iframe overlay to not disappear, preventing the user from being able to click on anything.This is a quick fix that overrides
process.platform, to make it not crash.Fixes: #11773, #12064, #12212
Duplicate of #12121?