-
-
Notifications
You must be signed in to change notification settings - Fork 27.1k
allow disabling of clearConsole() via env var #11573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @forana! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Bump |
Man this would be a nice feature. No idea why the CRA maintainers are so opposed to it. |
I'd love at least a response from the code owners, instead of leaving this sitting unanswered for over a year. |
Happy second birthday 🎉 |
Happy thirthday 🎉 |
This subtle change would vastly improve my developer experience. Would love to see it implemented soon. |
This PR proposes an unobtrusive workaround for the pain described in #7233 that results in a bad development experience. With this PR, setting the
CRA_CLEAR_CONSOLE
env var tofalse
causesclearConsole()
not to be called.I'm not particularly attached to the variable name, but I could not find a clear convention to match from this repo.