Skip to content

Conversation

forana
Copy link

@forana forana commented Oct 22, 2021

This PR proposes an unobtrusive workaround for the pain described in #7233 that results in a bad development experience. With this PR, setting the CRA_CLEAR_CONSOLE env var to false causes clearConsole() not to be called.

I'm not particularly attached to the variable name, but I could not find a clear convention to match from this repo.

@forana forana requested review from iansu and mrmckeb as code owners October 22, 2021 12:11
@facebook-github-bot
Copy link

Hi @forana!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale
Copy link

stale bot commented Jan 8, 2022

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 8, 2022
@forana
Copy link
Author

forana commented Jan 10, 2022

Bump

@uclaeamsavino
Copy link

Man this would be a nice feature. No idea why the CRA maintainers are so opposed to it.

@forana
Copy link
Author

forana commented Dec 7, 2022

I'd love at least a response from the code owners, instead of leaving this sitting unanswered for over a year.

@forana
Copy link
Author

forana commented Oct 30, 2023

Happy second birthday 🎉

@forana
Copy link
Author

forana commented Oct 30, 2024

Happy thirthday 🎉

@bgert
Copy link

bgert commented Oct 30, 2024

This subtle change would vastly improve my developer experience. Would love to see it implemented soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants