feat: add PROFILE environment variable as alternative to --profile flag #11239
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FezVrasta
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
@ianschmitz @iansu @mrmckeb @petetnt any chance to get this PR reviewed please? |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
Not stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this small addition would be very useful to make it easier to conditionally build profiling-enabled builds on CI environments.
Rather than having to redefine the installation script it's enough to set the
PROFILEenvironment variable totrue.Basically, with this, I could have a
.env.developmentwithPROFILE=trueto automatically make my development (not local) environment builds include the profiling build of React DOM