Fix InArray filter for object items #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heiglandreas
added a commit
to heiglandreas/php-document-store
that referenced
this pull request
Oct 3, 2019
This modifies the InArrayFilter to handle Objects similar to the way that the [PostgreSQL-Store handles them](event-engine/php-postgres-document-store#4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes event-engine/php-document-store#4
I've added some tests for the
InArrayfilter. It worked correctly when querying for example an array of tags (string[]) but failed to filter documents that contain an array of objects with a filter that queries a subkey of the objects insight the array (see added tests for details).The problem could be fixed by surrounding the json_encoded
InArrayfilter value with square brackets. Found the solution here