Skip to content

Use iLike for case insensitive like queries #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2020
Merged

Use iLike for case insensitive like queries #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/PostgresDocumentStore.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,7 @@ private function filterToWhereClause(Filter $filter, $argsCount = 0): array
$propParts = explode('->', $prop);
$lastProp = array_pop($propParts);
$prop = implode('->', $propParts) . '->>'.$lastProp;
return ["$prop LIKE :a$argsCount", ["a$argsCount" => $filter->val()], ++$argsCount];
return ["$prop iLIKE :a$argsCount", ["a$argsCount" => $filter->val()], ++$argsCount];
case DocumentStore\Filter\NotFilter::class:
/** @var DocumentStore\Filter\NotFilter $filter */
$innerFilter = $filter->innerFilter();
Expand Down
29 changes: 29 additions & 0 deletions tests/PostgresDocumentStoreTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
use EventEngine\DocumentStore\Filter\EqFilter;
use EventEngine\DocumentStore\Filter\GtFilter;
use EventEngine\DocumentStore\Filter\InArrayFilter;
use EventEngine\DocumentStore\Filter\LikeFilter;
use EventEngine\DocumentStore\Filter\LtFilter;
use EventEngine\DocumentStore\Filter\NotFilter;
use EventEngine\DocumentStore\Filter\OrFilter;
Expand Down Expand Up @@ -345,6 +346,34 @@ public function it_handles_not_any_of_id_filter()
$this->assertEquals(['bat'], $vals);
}

/**
* @test
*/
public function it_handles_case_insensitive_like_filter()
{
$collectionName = 'test_case_insensitive_like_filter';
$this->documentStore->addCollection($collectionName);

$firstDocId = Uuid::uuid4()->toString();
$secondDocId = Uuid::uuid4()->toString();
$thirdDocId = Uuid::uuid4()->toString();

$this->documentStore->addDoc($collectionName, $firstDocId, ['foo' => 'some BaR val']);
$this->documentStore->addDoc($collectionName, $secondDocId, ['foo' => 'some bAt val']);
$this->documentStore->addDoc($collectionName, $thirdDocId, ['foo' => 'SOME baz VAL']);

$filteredDocs = \iterator_to_array($this->documentStore->filterDocs(
$collectionName,
new LikeFilter('foo', '%bat%')
));

$vals = array_map(function (array $doc) {
return $doc['foo'];
}, $filteredDocs);

$this->assertEquals(['some bAt val'], $vals);
}

/**
* @test
*/
Expand Down