-
Notifications
You must be signed in to change notification settings - Fork 145
Stable stretch release #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We need to update the files in |
debian/changelog
Outdated
| @@ -1,3 +1,10 @@ | |||
| python-ev3dev (1.1.0) testing; urgency=medium | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WasabiFan, as I understood from #381 (comment), testing here is enough for the package to end up in the stretch repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong link. Should be #339 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of debian/compat, but it looks like that's already pointing to Stretch...
This is intended as an OpenRoberta-compatible release, which means it is still v1 and we don't need to rename the package. v2 would be the future release. |
|
Ok, that makes sense. Shouldn't we publish a Jessie release too to keep parity? Additionally, this branching feels wierd... Is your plan to cherry-pick the changelog commit to our develop branch later? |
Functionally, this is on par with our jessie release, so I don't see the need to update that.
This is actually far behind our develop branch, so I don't see how we could do that. |
The current Jessie release lacks the motor pair classes, I believe. Same with the friendly errors.
That's the idea behind git cherry-pick: apply the patch from a commit or multiple commits to a separate commit history line (i.e., different parent, but same changes and author). I suppose the question I'm really asking is: was your plan to work off of this branch in the future? Or something else? |
Hmm, then I would just drop those commits from this branch as well. The idea is provide a version minimally compatible with stretch but otherwise identical to our last jessie release, to make @ensonic happy.
I understand how the cherry-pick works, but I would just start from scratch with the changelog when we are ready to release v2. Again, I consider this branch a dead-end only meant to keep OpenRoberta afloat while we are working on v2. |
|
OK, that seems fine to me. I do believe that you'll want to drop some of the intermediate changes from this branch to keep parity with the current Jessie release. |
|
Kept #366, dropped the rest. |
WasabiFan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Not an expert on Debian packaging though.
|
@ddemidov How'd releasing this go? Did you get it published or were there still some packaging issues? |
|
I am stuck with #381 (comment). |
|
Following up to #381 (comment) I have the following in Edit: I think the reason I have |
|
Here is how travis runs pbuilder-ev3dev: https://github.com/ev3dev/pbuilder-ev3dev/blob/master/.travis.yml#L15 Maybe there is a missing dependency in the package? |
|
Also, some other repositories use pbuilder-ev3dev in travis sucessfully: https://github.com/ev3dev/brickman/blob/ev3dev-stretch/.travis.yml |
|
Here is a successful log to compare: https://travis-ci.org/ev3dev/brickman/jobs/214739979#L1357 One thing I noticed is that After that is that we discussed already. Perhaps none of these commands are in |
|
I have also updated http://www.ev3dev.org/docs/devtools/installing-the-ev3dev-archive/ There is a new PPA for getting ev3dev development tools. I'm not sure if it has a newer version of pbuilder-ev3dev or not. |
|
Missing gnupg was fixed in pbuilder-ev3dev v1.0.1: ev3dev/pbuilder-ev3dev@e8c7da1 |
|
It was an error on my side. I had an outdated version of Sorry for the noise. |
|
Closed this by mistake. I've pushed the changes to |
Branched
stretch-stableoff ofjessie, bumped it to 06ae05f and added a changelog entry.See #381 (comment)