txmgr: replace UseCellProofs flag with CellProofTime flag
#17649
+72
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoknee
changed the title
UseCellProofs flag with CellProofTime flag
![almanax-ai[bot]](https://avatars.githubusercontent.com/in/934833?s=60&v=4){kind=small}
geoknee
added
the
H-l1-fusaka-defense
sebastianst
reviewed
Sep 29, 2025
| ReceiptQueryInterval: 50 * time.Millisecond, | ||
| NetworkTimeout: 2 * time.Second, | ||
| TxNotInMempoolTimeout: 2 * time.Minute, | ||
| CellProofTime: math.MaxUint64, |
There was a problem hiding this comment.
Wondering if we will soon need to change this to the L1 Osaka time of the test calling this?
| EnvVars: prefixEnvVars("TXMGR_ENABLE_CELL_PROOFS"), | ||
| &cli.Uint64Flag{ | ||
| Name: CellProofTimeFlagName, | ||
| Usage: "Enables cell proofs in blob transactions for Fusaka (EIP-7742) compatibility from the provided unix timestamp. Set to the L1 Fusaka time. May be left blank for Ethereum Mainnet or Sepolia L1s.", |
There was a problem hiding this comment.
Suggested change
| Usage: "Enables cell proofs in blob transactions for Fusaka (EIP-7742) compatibility from the provided unix timestamp. Set to the L1 Fusaka time. May be left blank for Ethereum Mainnet or Sepolia L1s.", | |
| Usage: "Enables cell proofs in blob transactions for Fusaka (EIP-7742) compatibility from the provided unix timestamp. Should be set to the L1 Fusaka time. May be left blank for Ethereum Mainnet or Sepolia L1s.", |
| } | ||
|
|
||
| func fallbackToOsakaCellProofTimeIfKnown(chainID *big.Int, cellProofTime uint64) uint64 { | ||
| if cellProofTime != math.MaxUint64 { |
There was a problem hiding this comment.
Wondering if we want to do
Suggested change
| if cellProofTime != math.MaxUint64 { | |
| if cellProofTime != defaults.CellProofTime { |
here instead?
Comment on lines
+489
to
+503
| if chainID.Cmp(params.MainnetChainConfig.ChainID) == 0 { | ||
| if params.MainnetChainConfig.OsakaTime == nil { | ||
| return math.MaxUint64 // not yet scheduled, so we never use cell proofs | ||
| } else { | ||
| return *(params.MainnetChainConfig.OsakaTime) | ||
| } | ||
| } | ||
|
|
||
| if chainID.Cmp(params.SepoliaChainConfig.ChainID) == 0 { | ||
| if params.SepoliaChainConfig.OsakaTime == nil { | ||
| return math.MaxUint64 | ||
| } else { | ||
| return *(params.SepoliaChainConfig.OsakaTime) | ||
| } | ||
| } |
There was a problem hiding this comment.
Could shorten this a bit to
Suggested change
| if chainID.Cmp(params.MainnetChainConfig.ChainID) == 0 { | |
| if params.MainnetChainConfig.OsakaTime == nil { | |
| return math.MaxUint64 // not yet scheduled, so we never use cell proofs | |
| } else { | |
| return *(params.MainnetChainConfig.OsakaTime) | |
| } | |
| } | |
| if chainID.Cmp(params.SepoliaChainConfig.ChainID) == 0 { | |
| if params.SepoliaChainConfig.OsakaTime == nil { | |
| return math.MaxUint64 | |
| } else { | |
| return *(params.SepoliaChainConfig.OsakaTime) | |
| } | |
| } | |
| var osakaTime *uint64 | |
| if chainID.Cmp(params.MainnetChainConfig.ChainID) == 0 { | |
| osakaTime = params.MainnetChainConfig.OsakaTime | |
| } else if chainID.Cmp(params.SepoliaChainConfig.ChainID) == 0 { | |
| osakaTime = params.SepoliaChainConfig.OsakaTime | |
| } | |
| if osakaTime != nil { | |
| return *osakaTime | |
| } |
There was a problem hiding this comment.
And do we want to add Holesky here?
| } | ||
| // Use configuration to determine whether to enable cell proofs | ||
| if sidecar, blobHashes, err = MakeSidecar(candidate.Blobs, m.cfg.EnableCellProofs); err != nil { | ||
| useCellProofs := m.cfg.CellProofTime < uint64(time.Now().Unix()) |
There was a problem hiding this comment.
Probably good enough for this one-time event.
I'm wondering though how the batcher will behave around the L1 activation time. If a blob tx is being submitted while L1 activates Osaka, there may be RPC errors because of wrong non-cell proofs. How would this play out? Would this error stop the current submission loop and this craftTx would be entered again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17634
Description
Tests
Additional context
Metadata