Skip to content

Conversation

avorylli
Copy link

Problem

Issue #17084

Acceptance tests were failing intermittently during initialization with:

  • 404 errors when getting balance from faucet
  • "Waiting for online" timeouts when L1 network couldn't connect to EL node

Root Cause

Race conditions during system initialization where tests tried to use services before they were fully ready.

Solution

  • Enhanced EL node readiness checks with increased timeouts (10s → 30s)
  • Added pre-flight checks before balance requests
  • Increased faucet retry attempts (3 → 5)
  • Added explicit network readiness checks in tests
  • Improved synchronization with safety delays
  • Added retry utilities for better error handling

Files Changed

  • op-devstack/dsl/eoa.go - Enhanced balance lookup
  • op-devstack/dsl/el.go - Improved readiness checks
  • op-devstack/dsl/faucet.go - Enhanced retry logic
  • op-devstack/dsl/funder.go - Added safety delays
  • op-devstack/dsl/retry_utils.go - New retry utilities
  • op-acceptance-tests/tests/base/faucet_test.go - Added readiness checks
  • op-acceptance-tests/tests/base/deposit/deposit_test.go - Added readiness checks

@avorylli avorylli requested review from a team as code owners August 16, 2025 20:31
@opgitgovernance opgitgovernance added the S-stale Status: Will be closed unless there is activity label Aug 31, 2025
@opgitgovernance
Copy link

This pr has been automatically marked as stale and will be closed in 5 days if no updates

@avorylli
Copy link
Author

@smartcontracts @pcw109550

@pcw109550 pcw109550 removed the S-stale Status: Will be closed unless there is activity label Sep 2, 2025
@pcw109550
Copy link
Contributor

/ci authorize 83bc576

@opgitgovernance opgitgovernance added the S-stale Status: Will be closed unless there is activity label Sep 26, 2025
@opgitgovernance
Copy link

This pr has been automatically marked as stale and will be closed in 5 days if no updates

@avorylli
Copy link
Author

@pcw109550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-stale Status: Will be closed unless there is activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants