Skip to content

Currently components are taken from master which not always builds. #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tomaszduda23
Copy link

Add command which recrate libs in the same version as in arduino-esp32.

Add command which recrate libs in the same version as in arduino-esp32.
@tomaszduda23
Copy link
Author

It would be better to use android core as reference. Please review it first if you like idea I can change that.

@Jason2866
Copy link
Contributor

Imho a good idea. Not the first time, this generates issues espressif/arduino-esp32#7218
LittleFS was broken already too, not to build. It just didnt work anymore.

@me-no-dev
Copy link
Member

still I do not like limiting all components to some version. It is like pinning IDF to some commit from now on. How would we get the new features and fixes? Keep in mind that this is a tool that is used to update Arduino's libs. It does not have to always build successfully :) @tomaszduda23 if you rework this to be able to specify only particular components, we can move forward with merging. Some have submodules and some do not and some that do have submodules should not fetch them (tinyusb)

@Jason2866
Copy link
Contributor

Jason2866 commented Oct 14, 2022

Since i stumbled in this issue not only one time, i did choose a different approach. Forked IDF and integrated the needed stuff as submodules (easily update of used commit for a submodule). Left tinyusb in Arduino LibBuilder and using latest release version (without the unneeded submodules).
For our use case it is more important to use only the latest fixes/changes in IDF and Arduino and use known working 3rd party modules. Now it is up to us to decide when we want to use (test) new versions of the submodules. It is easier to check from time to time as finding issues coming "out of the dark".

@me-no-dev Not building successfully is no problem. Thats obvious. The problem is with hidden issues which does NOT break compile!
I found a solution for us, so tbh i dont care if this change will find its way into. Imho it would be a good idea to change.

@tomaszduda23
Copy link
Author

I'm doing some project so I needed libs with debug logs. If it does not build is pretty painful to figure out was is wrong.
I do understand that someone wants to use latest so I added new flag.

echo " -r Recreate arduino-esp32 libs in give version"

If you don't use -r it should work old way. Build command look like that.

./build.sh -I v4.4.2 -r -t esp32s2

@tomaszduda23
Copy link
Author

You need to specify git hash to rebuild in specific version so you can just export some of them if you would like to update one by one. For me important point I that I'm able to have the same libs version as in release.

AR_REPO_VERSION=55d608e3
CAMERA_REPO_VERSION=5611989
DL_REPO_VERSION=f3006d7
SR_REPO_VERSION=b578f17
RMAKER_REPO_VERSION=3736c12
DSP_REPO_VERSION=401faf8
LITTLEFS_REPO_VERSION=485a037
TINYUSB_REPO_VERSION=111515a29

@tomaszduda23
Copy link
Author

Since i stumbled in this issue not only one time, i did choose a different approach. Forked IDF and integrated the needed stuff as submodules (easily update of used commit for a submodule). Left tinyusb in Arduino LibBuilder and using latest release version (without the unneeded submodules).

I though about this also but I wanted to keep backward compatibility since I don't know all use cases for this.

@Jason2866
Copy link
Contributor

@tomaszduda23 I do find your solution nice! Would have choosen this way, if bash scripting would be not so...

@me-no-dev
Copy link
Member

I have a different idea. I'll create a PR with it and we could discuss which is better/more flexible

@tomaszduda23
Copy link
Author

Any update?

@me-no-dev me-no-dev closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants