-
Notifications
You must be signed in to change notification settings - Fork 181
Currently components are taken from master which not always builds. #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add command which recrate libs in the same version as in arduino-esp32.
It would be better to use android core as reference. Please review it first if you like idea I can change that. |
Imho a good idea. Not the first time, this generates issues espressif/arduino-esp32#7218 |
still I do not like limiting all components to some version. It is like pinning IDF to some commit from now on. How would we get the new features and fixes? Keep in mind that this is a tool that is used to update Arduino's libs. It does not have to always build successfully :) @tomaszduda23 if you rework this to be able to specify only particular components, we can move forward with merging. Some have submodules and some do not and some that do have submodules should not fetch them (tinyusb) |
Since i stumbled in this issue not only one time, i did choose a different approach. Forked IDF and integrated the needed stuff as submodules (easily update of used commit for a submodule). Left tinyusb in Arduino LibBuilder and using latest release version (without the unneeded submodules). @me-no-dev Not building successfully is no problem. Thats obvious. The problem is with hidden issues which does NOT break compile! |
I'm doing some project so I needed libs with debug logs. If it does not build is pretty painful to figure out was is wrong.
If you don't use -r it should work old way. Build command look like that.
|
You need to specify git hash to rebuild in specific version so you can just export some of them if you would like to update one by one. For me important point I that I'm able to have the same libs version as in release.
|
I though about this also but I wanted to keep backward compatibility since I don't know all use cases for this. |
@tomaszduda23 I do find your solution nice! Would have choosen this way, if bash scripting would be not so... |
I have a different idea. I'll create a PR with it and we could discuss which is better/more flexible |
Any update? |
Add command which recrate libs in the same version as in arduino-esp32.