fix(deploy): Increase page limit and add pagination to releases #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request improves API pagination in several functions within tools/config.sh by increasing page limits and refactoring functions for paginated release and asset lookups.
- Increased page limits in github_get_libs_idf and github_commit_exists.
- Introduced while loops for paginated fetching in github_release_id and github_release_asset_id.
lucasssvaz
force-pushed
the
fix/deploy_check
branch
from
32abf10 to
1a35d2d
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the pagination logic in the deployment scripts to support a larger set of paginated API responses from GitHub. Key changes include:
- Increasing the page limit from 3 to 5 in functions retrieving library commits and commit existence.
- Refactoring github_release_id to iterate through multiple pages to locate a specific release tag.
- Refactoring github_release_asset_id to support pagination when looking up release asset IDs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates several functions in
tools/config.shto improve their handling of paginated API responses from GitHub. The changes increase the maximum number of pages processed in some functions and add pagination logic to others, ensuring more comprehensive data retrieval.Enhancements to pagination logic:
github_get_libs_idffunction to allow for deeper searches through commit history.github_commit_existsfunction to improve the likelihood of finding a specific commit.Added support for paginated responses:
github_release_idfunction to include pagination logic, enabling it to search through multiple pages of releases to find a specific release ID.github_release_asset_idfunction to include pagination logic, allowing it to search through multiple pages of release assets to locate a specific asset ID.