Add missing import ssl
#820
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why is this? OS? |
|
For Windows, cygwin. On line 83 of the original the ssl module is used, but it is never imported. |
|
OK, but for Windows you have EXE to execute, and while I was compiling it on Windows, I had no issues or errors that class is not imported. Did you get errors? |
|
Yes. I got an error that the ssl module wasn't defined. I forget the exact
syntax. I ran get.py using python from a cygwin terminal. I'm not sure if
that's even supposed to work.
…On Fri, Nov 10, 2017 at 2:52 PM, Me No Dev ***@***.***> wrote:
OK, but for Windows you have EXE to execute, and while I was compiling it
on Windows, I had no issues or errors that class is not imported. Did you
get errors?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#820 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC9X3zCk-HbdiMIrP5WPLaZeaWW_6CMmks5s1NO4gaJpZM4QZCNO>
.
|
blue-2357
pushed a commit
to blue-2357/arduino-esp32
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.