Skip to content

Add LOLIN S3 Pro board def #8038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2023
Merged

Add LOLIN S3 Pro board def #8038

merged 2 commits into from
Apr 17, 2023

Conversation

@wemos
Copy link
Contributor

@wemos wemos commented Apr 6, 2023

Description of Change

Add LOLIN S3 Pro board based ESP32-S3.

Tests scenarios

I have tested my Pull Request on Arduino-esp32 core with ESP32-S3 Board with this scenario

Related links

https://www.wemos.cc/en/latest/s3/s3_pro.html

@me-no-dev me-no-dev requested a review from P-R-O-C-H-Y April 6, 2023 11:34
@VojtechBartoska VojtechBartoska added this to the 2.0.8 milestone Apr 12, 2023
@VojtechBartoska VojtechBartoska added Status: Review needed Issue or PR is awaiting review Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. labels Apr 12, 2023
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good :) LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Apr 14, 2023
@me-no-dev me-no-dev merged commit b4360dc into espressif:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels

Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.

Projects

Arduino ESP32 Core Project Roadmap
Status: Done

Milestone

2.0.8

Development

Successfully merging this pull request may close these issues.

4 participants

@wemos @P-R-O-C-H-Y @me-no-dev @VojtechBartoska