fix set/getSocketOption inheritance #7480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Already reviewed by @me-no-dev & @P-R-O-C-H-Y. @SuGlider please help with review and merge this. Thank you. |
|
Looks like a good fix. Nice work! |
SuGlider
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an exact replacement for #7270
Description of Change
int WiFiClient::fd() consttovirtual int WiFiClient::fd() constint WiFiClientSecure::fd() constsetSocketOption,getSocketOptionfromWiFiClientSecureto deduplicate the code.setSocketOption,getSocketOption,getOption, andsetOptioninWiFiClientoperate onfd(). With this fix they all operate on the correct socket.setNoDelayandgetNoDelaynow also works forWiFiClientSecure.Tests scenarios
tested using WiFiclientSecure and WiFiClient on esp32devkit v1, connected and setNoDelay.
Tested using the MQTT client as referenced to in the issue #7244
Related links
Closes #7244