Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added keywords.txt with RGB_BUILTIN into libraries/ESP32 #7015

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

PilnyTomas
Copy link
Contributor

Description of Change

Added new file keywords.txt into libraries/ESP32. The file currently contains only one entry for RGB_BUILTIN to be highlighted same as the original LED_BUILTIN.

Tests scenarios

Simply took a look in the Arduino IDE at constants RGB_BUILTIN and LED_BUILTIN - without this file only the LED_BUILTIN is highlighted.

Before change

before

After change

after

Related links

Addition to PR #6979

@PilnyTomas PilnyTomas self-assigned this Jul 20, 2022
@PilnyTomas PilnyTomas added the IDE: Arduino IDE Issue relates to Arduino IDE label Jul 20, 2022
@VojtechBartoska VojtechBartoska added this to the 2.0.5 milestone Jul 20, 2022
@SuGlider SuGlider self-requested a review July 20, 2022 13:14
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@SuGlider
Copy link
Collaborator

This is a very simple change. No need for further reviewing. I'll merge it.

@SuGlider SuGlider merged commit cc08dd3 into espressif:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDE: Arduino IDE Issue relates to Arduino IDE
Projects
Development

Successfully merging this pull request may close these issues.

3 participants