Skip to content

Add two more dfrobot microcontroller board definitions #6890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

wxzed
Copy link
Contributor

@wxzed wxzed commented Jun 21, 2022


Description of Change

Add two more dfrobot microcontroller board definitions.

Tests scenarios

compiles and can build projects.

Related links

Please provide links to related issue, PRs etc.

(eg. Closes #number of issue)

@CLAassistant
Copy link

CLAassistant commented Jun 21, 2022

CLA assistant check
All committers have signed the CLA.

@me-no-dev
Copy link
Member

Could you please sync with this PR: #6869

Which one should be merged? It seems they cover the same board.

@Arya11111
Copy link

Could you please sync with this PR: #6869

Which one should be merged? It seems they cover the same board.

@me-no-dev Already solved, Please try again this PR,thanks.

boards.txt Outdated
dfrobot_beetle_esp32c3.menu.DebugLevel.verbose.build.code_debug=5

##############################################################
dfrobot_firebeetle2_esp32s3.name=DFRobot Firebeetle 2 ESP32-S3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually both boards are added twice

dfrobot_firebeetle2_esp32s3.build.psram_type=qspi
dfrobot_firebeetle2_esp32s3.build.memory_type={build.flash_type}_{build.psram_type}

dfrobot_firebeetle2_esp32s3.menu.PSRAM.disabled=Disabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you really need all available flash/psram options? what modules are on the board?

dfrobot_beetle_esp32c3.menu.CPUFreq.10=10MHz
dfrobot_beetle_esp32c3.menu.CPUFreq.10.build.f_cpu=10000000L

dfrobot_beetle_esp32c3.menu.FlashMode.qio=QIO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question about flash options

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flash selection is reserved, and more modules may be added in the future

@wxzed
Copy link
Contributor Author

wxzed commented Jun 30, 2022

@me-no-dev Please see if there are any other questions

@me-no-dev me-no-dev merged commit fcd4799 into espressif:master Jun 30, 2022
@me-no-dev
Copy link
Member

@wxzed merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants