-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add two more dfrobot microcontroller board definitions #6890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could you please sync with this PR: #6869 Which one should be merged? It seems they cover the same board. |
@me-no-dev Already solved, Please try again this PR,thanks. |
boards.txt
Outdated
dfrobot_beetle_esp32c3.menu.DebugLevel.verbose.build.code_debug=5 | ||
|
||
############################################################## | ||
dfrobot_firebeetle2_esp32s3.name=DFRobot Firebeetle 2 ESP32-S3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually both boards are added twice
dfrobot_firebeetle2_esp32s3.build.psram_type=qspi | ||
dfrobot_firebeetle2_esp32s3.build.memory_type={build.flash_type}_{build.psram_type} | ||
|
||
dfrobot_firebeetle2_esp32s3.menu.PSRAM.disabled=Disabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you really need all available flash/psram options? what modules are on the board?
dfrobot_beetle_esp32c3.menu.CPUFreq.10=10MHz | ||
dfrobot_beetle_esp32c3.menu.CPUFreq.10.build.f_cpu=10000000L | ||
|
||
dfrobot_beetle_esp32c3.menu.FlashMode.qio=QIO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question about flash options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flash selection is reserved, and more modules may be added in the future
@me-no-dev Please see if there are any other questions |
@wxzed merged :) |
Description of Change
Add two more dfrobot microcontroller board definitions.
Tests scenarios
compiles and can build projects.
Related links
Please provide links to related issue, PRs etc.
(eg. Closes #number of issue)