Very slight difference between LoRa kit and WiFi kit. #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me-no-dev
reviewed
Sep 13, 2017
| @@ -52,8 +55,8 @@ static const uint8_t T4 = 13; | |||
| static const uint8_t T5 = 12; | |||
| static const uint8_t T6 = 14; | |||
| static const uint8_t T7 = 27; | |||
| static const uint8_t T8 = 33; | |||
| static const uint8_t T9 = 32; | |||
There was a problem hiding this comment.
Actually this is correct ;) 32 is T9 and 33 is T8
There was a problem hiding this comment.
Well that's interesting. The pinout diagram states gpio 33 = t8, but the espressif PDF states gpio 32 = t8.
|
Awesome :) thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the LoRa kit pinout was copied in for the WiFi kit.
If you reference http://esp32.net/images/Heltec/WIFI-Kit-32/Heltec_WIFI-Kit-32_DiagramPinout.jpg, you'll see a few differences, this PR should address them. I've only tested out the SPI pins and the LED_BUILTIN specifically.