Change disconnect function #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation does not disconnect the WiFi. Use of `esp_wifi_disconnect()` does.
|
have you tried calling that function first? void setup(){
//....
WiFi.disconnect(true);
WiFi.connect("ssid", "pass");
//....
}It should wipe the settings as well |
|
I was testing the disconnect directly. Ie configure the ESP to join an AP, then 10 seconds later call WiFi.disconnect(). It returned true, but nothing changed and the ESP still had an IP and was connected. |
|
you removed some lines that had a function there ;) |
|
Ah, is disconnect meant to wipe the settings too? |
|
what's up with this? |
put back the clear ssid + password remove the duplicate `esp_wifi_set_config(WIFI_IF_STA, &conf);`
|
holiday + forgot. sorry:) |
|
great :) |
Raienryu97
pushed a commit
to Raienryu97/arduino-esp32
that referenced
this pull request
Aug 2, 2017
* Change disconnect function Current implementation does not disconnect the WiFi. Use of `esp_wifi_disconnect()` does. * Update WiFiSTA.cpp put back the clear ssid + password remove the duplicate `esp_wifi_set_config(WIFI_IF_STA, &conf);`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation does not disconnect the WiFi. Use of
esp_wifi_disconnect()does.