Add "WEMOS LoLin32" boards support. #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me-no-dev
reviewed
Nov 8, 2016
| static const uint8_t SDA = 21; | ||
| static const uint8_t SCL = 22; | ||
|
|
||
| static const uint8_t SS = 2; |
There was a problem hiding this comment.
The ESP32's "General purpose SPI" can be remap to any GPIO
There was a problem hiding this comment.
true, but it will not work just by defining it here ;)
There was a problem hiding this comment.
OK I'm merging this now and will make the necessary adjustments to make your SS pin work.
Keep in mind that GPIO2 is a bootstrap pin that is pulled down by default (like GPIO15 on ESP8266) and that does not make it a very good SS pin, because it will have the slave selected on boot.
There was a problem hiding this comment.
I agree with you, changed the SS to GPIO5.
Thank you.
Lzw655
pushed a commit
to Lzw655/arduino-esp32
that referenced
this pull request
Oct 12, 2023
Update build.sh
brentru
pushed a commit
to adafruit/arduino-esp32
that referenced
this pull request
Oct 22, 2024
update esp8266 option names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@projectgus
@me-no-dev
Add "WEMOS LoLin32" boards support.
Thank you.