address review comments; move impl to cpp file for getTimeout, and re…

…move local variable for currentMillis

cores/esp32/Stream.cpp

@@ -82,6 +82,9 @@ void Stream::setTimeout(unsigned long timeout)  // sets the maximum number of mi
 {
     _timeout = timeout;
 }
+unsigned long Stream::getTimeout(void) {
+  return _timeout;
+}
 
 // find returns true if the target string is found
 bool Stream::find(const char *target)

cores/esp32/Stream.h

@@ -59,10 +59,7 @@ class Stream: public Print
 // parsing methods
 
     void setTimeout(unsigned long timeout);  // sets maximum milliseconds to wait for stream data, default is 1 second
-    unsigned long getTimeout(void)
-    {
-      return _timeout;
-    }
+    unsigned long getTimeout(void);
     bool find(const char *target);   // reads data from the stream until the target string is found
     bool find(uint8_t *target)
     {

libraries/WebServer/src/Parsing.cpp

@@ -308,14 +308,12 @@ int WebServer::_uploadReadByte(WiFiClient& client){
     // keep trying until you either read a valid byte or timeout
     unsigned long startMillis = millis();
     long timeoutIntervalMillis = client.getTimeout();
-    unsigned long currentMillis = startMillis;
     boolean timedOut = false;
     for(;;) {
       // loosely modeled after blinkWithoutDelay pattern
       while(!timedOut && !client.available() && client.connected()){
         delay(2);
-        currentMillis = millis();
-        timedOut = currentMillis - startMillis >= timeoutIntervalMillis;
+        timedOut = ((unsigned long) millis()) - startMillis >= timeoutIntervalMillis;
       }
 
       res = client.read();