New version of the Olimex boards ESP32-EVB/Gateway/PoE #2397
Conversation
In Board.txt file added board revision submenu to distinguish the different revisions of the same board. By selecting different revision in the Arduino menu different value of the predefined macro will be applied which is used inside the pins_arduino.h file to make different defines and values for the specific revision. In addition to this esp32-poe pin definitions is added ethernet power enable pin and also defined macro: BOARD_HAS_1BIT_SDMMC
Stanimir-Petev
changed the title
|
готово :) |
|
Hey we have some issues with the new definitions. The define which changes the board version causes warnings in Arduino. More info can be found here: #2463 |
|
@me-no-dev , thanks for the report! You and stickbreaker are right about it. I didn't notice that if a board different than ESP32-Gateway is selected there will be no revision submenu and thus no revision selected. As a result - no macro of the board will be defined at all. So it seems the line "#esp32-gateway.build.board=ESP32_GATEWAY" should be uncommented in order to solve this. This way if no revision is selected (which is in case of any other board chosen) there will be definition of the macro "ARDUINO_ESP32_GATEWAY" WITHOUT value, and if Gateway with revision is selected then we will have the same macro WITH value corresponding to the revision selected and depending on this value in the "pins_arduino.h" other macros will/won't be defined to match the hardware of the revision. It was just my mistake on testing not noticing this for which I apologize, and thanks for correcting me. PS: Should I create another pull request or you will just uncomment this line (1725)? |
|
@Stanimir-Petev you want to add a PR for this, or should I edit it myself? |
|
I don't think another pull request is needed since it is just one line that should be uncommented. |
|
628b8f0 |
In Board.txt file added board revision submenu for different revisions of the same board. By selecting different revision in the Arduino menu different value of the predefined macro will be applied which is used inside the pins_arduino.h file to make different defines and values for the specific revision.
Added PartitionScheme submenu to our 3 boards, similar to the other ESP32 boards.
In esp32-gateway pin defintions preprocessor conditions added to distingiush different revisions.
In esp32-poe pin definitions is added ethernet power enable pin and also defined macro: BOARD_HAS_1BIT_SDMMC.