Added boards constants for LED_BUILTIN and KEY_BUILTIN #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sources: * esp320: http://wiki.sweetpeas.se/index.php?title=ESP320#Developing_using_the_Arduino_IDE * esp32thing: https://cdn.sparkfun.com/assets/learn_tutorials/5/0/7/esp32-thing-schematic.pdf * espea32: https://github.com/AprilBrother/ESPea32/blob/master/hardware/ESPea32-schematic.pdf * hornbill32dev: https://github.com/ExploreEmbedded/Hornbill-ESP32-DEV/blob/master/Design%20Files/Schematic/Hornbill%20Devboard.pdf * lolin32: values from existing header * nano32: http://iot-bits.com/closer-look-esp32-nano32/ * node32s: https://github.com/lamloei/node32s-book/blob/master/ch01/node32s-schematic.pdf
me-no-dev
reviewed
Feb 6, 2017
variants/esp320/pins_arduino.h
Outdated
| @@ -9,6 +9,12 @@ | |||
| #define digitalPinToInterrupt(p) (((p)<40)?(p):-1) | |||
| #define digitalPinHasPWM(p) (p < 34) | |||
|
|
|||
| static const uint8_t LED_BUILTIN = 5; | |||
| static const uint8_t BUILTIN_LED = 5; | |||
There was a problem hiding this comment.
since those are the same, wouldn't it be better if one of them is define to forward to the other one?
There was a problem hiding this comment.
Yes, you are right, I will do it. I tried to do it same way as is in ESP8266 core.
Closed
|
Done. |
|
thanks :) |
darkxst
pushed a commit
to darkxst/arduino-esp32
that referenced
this pull request
Dec 5, 2024
* RTC reserves 512 only * RTC reserves 512 only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sources:
Note: Some board producers have not published schematics yet, so it was little digging work.