-
Notifications
You must be signed in to change notification settings - Fork 7.6k
smartConfig support #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smartConfig support #136
Conversation
return false; | ||
} | ||
|
||
return _smartConfigDone; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i do not see _smartConfigDone being set to true anywhere? Maybe missing from the callback?
@@ -498,3 +498,62 @@ IPv6Address WiFiSTAClass::localIPv6() | |||
} | |||
return IPv6Address(addr.addr); | |||
} | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not forget to add #include <esp_smartconfig.h>
up on top
Please see my comments, with those changes I have tested it and its working :) |
You might want to add an example as well :) |
Done that! @me-no-dev how did you test it? my example code doesn't seem to work. please verify. Thanks in advance. |
@seopyoon you did not add |
Done! I should've read your comments more thoroughly. Could you confirm my example .ini working? Thanks! |
Sketch filename should be the same as the folder name it's in. So change SmartConfig.ino to WiFiSmartConfig.ino
Please do test your code and at least compile it. |
@me-no-dev modified name of file, added comments. Confirmed compiling, and running without error. But, I cannot make it connect via ESP Touch technology. I am using this app for Android. |
I also use the ESPTouch app from the App store (iPhone user here) and it was working. maybe check the android store for updated version? |
|
Hello, |
…t-install Only install clang-format if it is really missing
I added smart Config support for the library.
Based upon ESP83266 arduino library.
Haven't had chance to confirm it working.