Skip to content

Add Core Debug Level for WeMosBat #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Conversation

stickbreaker
Copy link
Contributor

Should we add this declaration option for all boards?

Should we add this declaration option for all boards?
@JamesGKent
Copy link

adding it for all boards would simplify asking people to turn on logging for debug purposes...
i'd vote in favour of adding it, even though same thing can be achieved by using the ESP Dev module board option...

@stickbreaker
Copy link
Contributor Author

@JamesGKent As long as the pin definitions and Flash speeds are the same.

Chuck.

@JamesGKent
Copy link

@stickbreaker i hadn't considered that, in which case i'd definitely advocate that the debug menu should be added to all boards

@me-no-dev
Copy link
Member

I think that a better way should be found to organize the boards better. the config file is a zoo of boards that are actually all the same...

@me-no-dev me-no-dev merged commit 7eb6fc5 into espressif:master Apr 6, 2018
@stickbreaker stickbreaker deleted the patch-2 branch April 6, 2018 16:41
Curclamas pushed a commit to Curclamas/arduino-esp32 that referenced this pull request Aug 21, 2018
Should we add this declaration option for all boards?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants