Skip to content

fix(example): led flash not working if not using default model in camera example. #11466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(example): led flash not working if not using default model in camera example. #11466

wants to merge 1 commit into from
+3 −2

Conversation

HighDoping
Copy link

Description of Change

LED flash do not work on some boards with esp32-cam example because the pin is always set to 22. This PR changes the pin definition to be set dynamically by setupLedFlash().

Tests scenarios

I have tested my Pull Request on Arduino-esp32 core v3.2.0 with AI Thinker ESP32-CAM

@HighDoping HighDoping requested a review from a team as a code owner June 14, 2025 01:44
@CLAassistant
Copy link

CLAassistant commented Jun 14, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 14, 2025 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello HighDoping, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 02b2e28

@P-R-O-C-H-Y P-R-O-C-H-Y added Type: Example Issue is related to specific example. Status: Review needed Issue or PR is awaiting review labels Jun 16, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from lucasssvaz June 16, 2025 06:54
@P-R-O-C-H-Y P-R-O-C-H-Y changed the title fix(esp32): led flash not working if not using default model in esp32-cam example. fix(example): led flash not working if not using default model in camera example. Jun 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30⚠️ +320.000.000⚠️ +160.00⚠️ +0.03
ESP32S20⚠️ +160.000.00000.000.00
ESP320⚠️ +200.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAM
libraries/ESP32/examples/Camera/CameraWebServer------
ESP32/examples/Camera/CameraWebServer (2)⚠️ +200⚠️ +160⚠️ +200
ESP32/examples/Camera/CameraWebServer (3)⚠️ +32⚠️ +16----

me-no-dev
me-no-dev reviewed Jun 16, 2025
View reviewed changes
libraries/ESP32/examples/Camera/CameraWebServer/app_httpd.cpp
#define CONFIG_LED_MAX_INTENSITY 255

int led_pin = 22; // Store the actual LED pin used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

22 is invalid GPIO on some chips. Code should be reworked so that CONFIG_LED_ILLUMINATOR_ENABLED and LED_LEDC_GPIO are defined in the camera board config and not just be enabled by default

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for review, I'm working on a version that use #if defined(LED_GPIO_NUM) to check if LED is available.
I'll test on real hardware this weekend and upload the new fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev me-no-dev left review comments

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@lucasssvaz lucasssvaz Awaiting requested review from lucasssvaz

Assignees
No one assigned
Labels
Status: Review needed Issue or PR is awaiting review Type: Example Issue is related to specific example.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HighDoping @CLAassistant @me-no-dev @P-R-O-C-H-Y