Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2017 bt fix #11216

Closed
wants to merge 142 commits into from
Closed

2017 bt fix #11216

wants to merge 142 commits into from

Conversation

mikandrzej
Copy link

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.


Description of Change

Please describe your proposed Pull Request and it's impact.

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.

(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)

Related links

Please provide links to related issue, PRs etc.

(eg. Closes #number of issue)

me-no-dev and others added 30 commits February 8, 2023 17:06
…use with RS485 auto RTS (espressif#7935)

* Added setMode function to set the esp32 uart mode

Used to set the esp32 uart mode for use with RS485 Half Duplex and the auto RTS pin mode. This will set/clear the RTS pin output to control the RE/DE pin on most RS485 chips.

* Add Success (bool) return in some functions

* Add Success (bool) return code to some functions

* Add Success (bool) return to some functions

* Add Success (bool) return to some functions

* Fix uartSetRxTimeout return type

---------

Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
…spressif#7913)

* Add v2.0.7 in issue template (espressif#7871)

* Fix the F_CPU frequency for the ESP32-S3

Hello, I was using the FastLED library and it was complaining about F_CPU not being defined. So, I just noticed that it is not defined for the ESP32-S3 module. So I made this change in the header file and it compiled. Therefore I wanted to propose this change to the HAL library to improve compatibility. Thank you for your time.

* Makes F_CPU generic based on the SoC frequency

Works for ESP32, ESP32C3, ESP32S2, ESP32S3

* Includes ESP32C3 in the F_CPU definition

Necessary for ESP32 Arduino Core 2.0.x based on IDF 4.4

---------

Co-authored-by: Vojtěch Bartoška <76958047+VojtechBartoska@users.noreply.github.com>
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
Fixed library crash on low memory where `new char[1460];` throws an exception.  `malloc` is a safe drop in replacement.
Revert to previous definition of `FPSTR` and `F` macros.
powerfeatherdev and others added 26 commits March 5, 2024 10:54
* Add support for ESP32-S3 PowerFeather

* Replace GPIO_NUM_X with just the pin number

* Pattern powerfeather entries after generic s3 board

* Remove redefinitions, add pin aliases to pins_arduino.h

* Fix and add pin definitions

Add pins D7, D8
Correct pin numbers for ALARM and EN

* Enable CDC on boot

* Use partition schemes appropriate for flash size

Also adds another partition scheme based of off default_8MB, but fat
partition.

* Add some required definitions to pins_arduino.h
…ssif#9176)

* feat(uart): backports UART pin attachment from 3.0.0 to 2.0.15

* Fix (uart): Fixes additional Serial HardwareSerial errors for 2.0.14

* Update esp32-hal-uart.c

* Update HardwareSerial.h

* Apply suggestions from code review

* Fixes UartAvailableForWrite espressif#9319

* Fixes  (set RX/TX buffer size)
UART0 pins are set by ROM Boot to default values. This must be reflected into Arduino HardwareSerial in order to allow it to correctly detach it and then attach it to something else.

Summary:
UART0 constructor sets default RX/TX pins as done in boot time.
* feat: backport variants from 3.0.0

* heltec update from espressif#9367
* Adjust Update Library license

* Update Update.h

* Update Updater.cpp
* Handle large octet-stream

* Add exemple Upload Huge File

* Remove unuse function printDirectory

* Fix upload path

* Simplify and generalize the body parsing.
* feat: backports HWCDC

* fix: statement order

* feat: Apply suggestions from code review

* Create HWCDC_Events.ino

* Create .skip.esp32

* Create .skip.esp32s2

* Delete libraries/ESP32/examples/HWSerial_Events/.skip.esp32s2

* Delete libraries/ESP32/examples/HWSerial_Events/.skip.esp32

* Delete libraries/ESP32/examples/HWSerial_Events/HWSerial_Events.ino
Changed header files to use the same IDF buffer limits.

* this is a backport from PR espressif#9554
Roll back as it was merged directly instead of creating a PR.
…if#9561)

* feat (uart): uses the same IDF 32bits size for TX/RX buffers

Uses the same IDF 32bits size for TX/RX buffers.

Changed header files to use the same IDF buffer limits.
* this is a backport from PR espressif#9554

* feat (uart): change UART events logs to Verbose 

UART events like BREAK or errors are now Verbose instead of Warning Level.

Backporting change from Issue espressif#9551

* feat (uart): uses the same IDF 32bits size for TX/RX buffers.

Uses the same IDF 32bits size for TX/RX buffers.

Changed header files to use the same IDF buffer limits.
* this is a backport from PR espressif#9554

* feat (uart): keep overflow log as warning

Keeps Overflow /  Buffer Full log messages in Warning Level.
Setting programmer.default has unfortunately multiple effects:
- sets the tick by default in the Tool menu in the IDE (which was the
  expected behavior),
- forces the CLI to use the specified programmer every time an upload is
  attempted (which is confusing users).

For this reason, it is better to remove the "programmer.default" setting
from the board definition and let the user choose the programmer in the
IDE menus, as it was before.
@CLAassistant
Copy link

CLAassistant commented Apr 2, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
9 out of 10 committers have signed the CLA.

✅ Viproz
✅ pillo79
✅ Jason2866
✅ SuGlider
✅ powerfeatherdev
✅ SwapnilPande
✅ mariopesch
✅ nathannau
✅ kiran-desilva
❌ mikandrzej
You have signed the CLA already but the status is still pending? Let us recheck it.

@mikandrzej mikandrzej closed this Apr 2, 2025
@mikandrzej mikandrzej deleted the 2017_bt_fix branch April 2, 2025 22:12
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message " Implement official Arduino IDE debugger API on 2.x (#9118)":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "Add Arduino Nano ESP32 target (#8417)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add Arduino Nano ESP32 target (#8417)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add and init new LittleFS options (#9122)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add required callbacks for TinyUSB DFU":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add required callbacks for TinyUSB DFU":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add setMode function HardwareSerial.c to set the esp32 uart mode for use with RS485 auto RTS (#7935)":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "Add setMode function HardwareSerial.c to set the esp32 uart mode for use with RS485 auto RTS (#7935)":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "Add support for esp-elf-gdb":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add support for esp-elf-gdb":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add support for the MotorGo Mini board (#9269)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Added isKey documentation for the Preferences library (#9142)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Adjust Update Library license (#9448)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Backport fix linker failure (#9121)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Backport: ArduinoOTA upload intermittent failure fixed (#9215)":
    • type/action should start with a lowercase letter
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]
  • the commit message "Backport: Fix ESP32-Solo WDT on HTTP OTA update (#9223)":
    • type/action should start with a lowercase letter
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]
  • the commit message "BugFix FlashStringHelper Macros (#8143)":
    • summary looks empty
    • type/action looks empty
  • the commit message "BugFix FlashStringHelper Macros (#8143)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Define Wire1 pins for ESP32-S3 PowerFeather (#9398)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Disable Ethernet library if CONFIG_ETH_ENABLED not defined in sdkconfig.h (#8595)":
    • summary looks empty
    • type/action looks empty
  • the commit message "ESP32-S3 PowerFeather Support for v2.x (#9325)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Enable DFU":
    • summary looks empty
    • type/action looks empty
  • the commit message "Enable DFU":
    • summary looks empty
    • type/action looks empty
  • the commit message "Enable JSON upload to releases page":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix AP DHCPS not properly working on recent IDF":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix compilation issue caused by ESP-Insights":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix compilation issue caused by ESP-Insights":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix escaping issues in 2.0.10 (#8433)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix escaping issues in 2.0.10 (#8433)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix pin attachInterrupt(digitalPinToInterrupt(48)) on all S3 based SOCs (#8600)":
    • probably contains Jira ticket reference (ESP-100). Please remove Jira tickets from commit messages.
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix the F_CPU frequency definition for the ESP32-S3 in esp32-hal.h (#7913)":
    • footer's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "Fixes ESP32-S2 CDC Debug Logging (#7284)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fixes EspClass::deepSleep(64 bits) (#9077)":
    • summary looks empty
    • type/action looks empty
  • the commit message "HTTPClient - Fix case sensitiveness for header keys (#8632)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Handle large octet-stream (#9430)":
    • summary looks empty
    • type/action looks empty
  • the commit message "I2S - Revert espressif/esp-idf@73ca054 to fix I2S crackling (#8583)":
    • summary looks empty
    • type/action looks empty
  • the commit message "I2S - Revert espressif/esp-idf@73ca054 to fix I2S crackling (#8583)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF 38eeba213a (#9339)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Nano ESP32 file system option (#8566)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Nano ESP32 file system option (#8566)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Nano ESP32: add debug support (#8567)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Nano ESP32: add debug support (#8567)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Nano ESP32: add pin numbering option (#8565)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Nano ESP32: add pin numbering option (#8565)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Nano ESP32: fix digital, analog and GPIO pin counts (#8586)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Nano ESP32: fix digital, analog and GPIO pin counts (#8586)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Remove -Werror=all from build flags, but enable it in CI":
    • summary looks empty
    • type/action looks empty
  • the commit message "Remove insights component since it's provided by RainMaker":
    • summary looks empty
    • type/action looks empty
  • the commit message "Remove insights component since it's provided by RainMaker":
    • summary looks empty
    • type/action looks empty
  • the commit message "Rename variants/heltec_wifi_kit_32_V3 to match entry in boards.txt. (#8886)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Restore 2.x RX1/TX1 RX2/TX2 pins":
    • summary looks empty
    • type/action looks empty
  • the commit message "SD library: Fix format (#9124)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Set ref to 2.0.13 (#8615)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Support relative paths in UNIX search PATH (#8622)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Uart detach 2.0.13 (#8629)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update ESP-IDF libs to v4.4.4":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update ESP-IDF libs to v4.4.4":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update ESP-IDF to v4.4.5":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update ESP-IDF to v4.4.5":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update ESP-IDF to v4.4.6 (with I2S Rollback) (#8701)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update RainMaker and components":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update RainMaker and components":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update core version to 2.0.10":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update core version to 2.0.10":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update core version to 2.0.14":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update core version to 2.0.15":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update esp32-hal-rgb-led.c (#9374)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update esptool to v4.4":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update esptool to v4.4":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update esptool to v4.5":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update esptool to v4.5":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update esptool to v4.5.1":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update esptool to v4.5.1":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update get.py to support Apple ARM64":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update get.py to support Apple ARM64":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update package version":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update package version":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update package_esp32_index.template.json":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update package_esp32_index.template.json":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update toolchains and openocd for ESP-IDF v4.4.4":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update toolchains and openocd for ESP-IDF v4.4.4":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update version and prevent the release script from updating the jsons":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update version to 2.0.11":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update version to 2.0.11":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update version to 2.0.17":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update version to 2.0.8":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update version to 2.0.8":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update version to 2.0.9":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update version to 2.0.9":
    • summary looks empty
    • type/action looks empty
  • the commit message "Updated led pins to match latest board revision (#9298)":
    • summary looks empty
    • type/action looks empty
  • the commit message "WFG Crashfix (#8043)":
    • summary looks empty
    • type/action looks empty
  • the commit message "WFG Crashfix (#8043)":
    • summary looks empty
    • type/action looks empty
  • the commit message "WebServer: use MD5Builder instead of mbedtls (#9123)":
    • type/action should start with a lowercase letter
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]
  • the commit message "WiFiUDF Low memory fix (#8065)":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "WiFiUDF Low memory fix (#8065)":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty
  • the commit message "add senseBox MCU-S2 (#9263)":
    • summary looks empty
    • type/action looks empty
  • the commit message "backport: variants from 3.0.0 + fixes (#9381)":
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]
  • the commit message "backports HWCDC to v2.0.15 (#9462)":
    • summary looks empty
    • type/action looks empty
  • the commit message "feat (uart): uses the same IDF 32bits size for TX/RX buffers (#9561)":
    • footer must have leading blank line
    • summary looks empty
    • type/action looks empty
  • the commit message "fix attach pin for S3":
    • summary looks empty
    • type/action looks empty
  • the commit message "fix attach pin for S3":
    • summary looks empty
    • type/action looks empty
  • the commit message "fix":
    • summary looks empty
    • type/action looks empty
  • the commit message "fix(adc): Always use default read resolution in __analogReadMilliVolts to obtain correct milliVolts value. (#9006)":
    • body's lines must not be longer than 100 characters
    • summary appears to be too long
  • the commit message "fix: HWCDC removed clearing USB Serial/JTAG interrupts during begin (#9316) (#9344)":
    • summary appears to be too long
  • the commit message "fix: UART0 boot pin setup (#9373)":
    • body's lines must not be longer than 100 characters
  • the commit message "fixes setPins return (#8644)":
    • summary looks empty
    • type/action looks empty
  • the commit message "io_pin_remap fixes for the Arduino Nano ESP32 (#8489)":
    • summary looks empty
    • type/action looks empty
  • the commit message "io_pin_remap fixes for the Arduino Nano ESP32 (#8489)":
    • summary looks empty
    • type/action looks empty
  • the commit message "roll back HardwareSerial.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "simplifying webserver file uploads via form POST (#9211)":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 This PR seems to be quite large (total lines of code: 134087), you might consider splitting it into smaller PRs

👋 Hello mikandrzej, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 0ebac88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.