Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext_lib): Fix ESPAsyncWebServer URL and examples #11160

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

lucasssvaz
Copy link
Collaborator

Description of Change

Fix ESPAsyncWebServer URL and examples

Tests scenarios

CI

Verified

This commit was signed with the committer’s verified signature.
lucasssvaz Lucas Saavedra Vaz
@lucasssvaz lucasssvaz added Type: CI & Testing lib_test Run External Libraries Test labels Mar 21, 2025
@lucasssvaz lucasssvaz self-assigned this Mar 21, 2025
Copy link
Contributor

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 6f2fa84

@lucasssvaz lucasssvaz marked this pull request as ready for review March 21, 2025 17:34
Copy link
Contributor

External libraries build test

Library ESP32 ESP32C3 ESP32C6 ESP32H2 ESP32P4 ESP32S2 ESP32S3
Adafruit NeoPixel 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅
ArduinoBLE 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ❌ -> 1 ❌ 1 ❌ -> 1 ❌ 1 ❌ -> 1 ❌ N/A 1 ✅ -> 1 ✅
ESP32Servo 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅
ESPAsyncWebServer 32 ✅ -> 32 ✅ 32 ✅ -> 32 ✅ 32 ✅ -> 32 ✅ 32 ✅ -> 32 ✅ 32 ✅ -> 32 ✅ 32 ✅ -> 32 ✅ 32 ✅ -> 32 ✅
EthernetESP32 2 ✅ -> 2 ⚠️ 2 ✅ -> 2 ✅ 2 ✅ -> 2 ✅ 2 ✅ -> 2 ✅ 2 ❌ -> 2 ❌ 2 ✅ -> 2 ✅ 2 ✅ -> 2 ✅
FastLED 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ⚠️ -> 1 ⚠️ 1 ⚠️ -> 1 ⚠️ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ⚠️
IRremote 1 ⚠️ -> 1 ⚠️ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ⚠️ -> 1 ⚠️ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅
MFRC522 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅
WS2812FX 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅
ZACwire for TSic 2 ✅ -> 2 ✅ 2 ✅ -> 2 ✅ 2 ✅ -> 2 ✅ 2 ✅ -> 2 ✅ 2 ✅ -> 2 ✅ 2 ✅ -> 2 ✅ 2 ✅ -> 2 ✅

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. btw the more examples you add the longer the CI will take. That's why before there were just few examples selected.

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Mar 24, 2025
Copy link
Contributor

External libraries build test

Library ESP32 ESP32C3 ESP32C6 ESP32H2 ESP32P4 ESP32S2 ESP32S3
Adafruit NeoPixel 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅
ArduinoBLE 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ❌ -> 1 ❌ 1 ❌ -> 1 ❌ 1 ❌ -> 1 ❌ N/A 1 ✅ -> 1 ✅
ESP32Servo 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅
ESPAsyncWebServer 32 ✅ -> 32 ✅ 32 ✅ -> 32 ✅ 32 ✅ -> 32 ✅ 32 ✅ -> 32 ✅ 32 ✅ -> 32 ✅ 32 ✅ -> 32 ✅ 32 ✅ -> 32 ✅
EthernetESP32 2 ✅ -> 2 ⚠️ 2 ✅ -> 2 ✅ 2 ✅ -> 2 ✅ 2 ✅ -> 2 ✅ 2 ❌ -> 2 ❌ 2 ✅ -> 2 ✅ 2 ✅ -> 2 ✅
FastLED 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ⚠️ -> 1 ⚠️ 1 ⚠️ -> 1 ⚠️ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ⚠️
IRremote 1 ⚠️ -> 1 ⚠️ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ⚠️ -> 1 ⚠️ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅
MFRC522 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅
WS2812FX 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅ 1 ✅ -> 1 ✅
ZACwire for TSic 2 ✅ -> 2 ✅ 2 ✅ -> 2 ✅ 2 ✅ -> 2 ✅ 2 ✅ -> 2 ✅ 2 ✅ -> 2 ✅ 2 ✅ -> 2 ✅ 2 ✅ -> 2 ✅

@me-no-dev me-no-dev merged commit cc2632b into espressif:master Mar 24, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib_test Run External Libraries Test Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants